Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4pplet Waffling80 Community Layout Support and Touch-Up #20932

Merged
merged 23 commits into from
May 14, 2023
Merged

4pplet Waffling80 Community Layout Support and Touch-Up #20932

merged 23 commits into from
May 14, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • fix Configurator key sequence
    image
  • adds a common info.json (matrix is identical between both revisions)
  • adds eighteen layout macros
  • enables Community Layout support

cc @4pplet (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

⚠ 4pplet/waffling80/rev_a: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

⚠ 4pplet/waffling80/rev_b: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft added 23 commits May 14, 2023 00:11
@noroadsleft
add matrix_diagram.md
c5c6d86
@noroadsleft
fix Configurator key sequence
6b08eb6
@noroadsleft
info.json: apply friendly formatting
a6af4f6
@noroadsleft
create common info.json
16f11dc 
Moves the data-driven keys which are common between Rev A and Rev B to a joint `info.json` file.
@noroadsleft
add LAYOUT_tkl_f13_ansi_split_space_split_bs_rshift
ad4d902
@noroadsleft
add LAYOUT_tkl_f13_ansi_split_bs_rshift
3835898
@noroadsleft
add LAYOUT_tkl_f13_ansi
6f0336c
@noroadsleft
add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift
339b7a6
@noroadsleft
add LAYOUT_tkl_f13_ansi_tsangan
652c5a1
@noroadsleft
add LAYOUT_tkl_ansi_split_bs_rshift
c2988ae
@noroadsleft
add LAYOUT_tkl_ansi
b3a9663
@noroadsleft
add LAYOUT_tkl_ansi_tsangan_split_bs_rshift
61113b0
@noroadsleft
add LAYOUT_tkl_ansi_tsangan
7d0fa91
@noroadsleft
add LAYOUT_tkl_f13_iso_split_space_split_bs_rshift
085a3ad
@noroadsleft
add LAYOUT_tkl_f13_iso_split_bs_rshift
da95e63
@noroadsleft
add LAYOUT_tkl_f13_iso
8f4c36f
@noroadsleft
add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift
dd7376e
@noroadsleft
add LAYOUT_tkl_f13_iso_tsangan
960d4ac
@noroadsleft
add LAYOUT_tkl_iso_split_bs_rshift
19fba09
@noroadsleft
add LAYOUT_tkl_iso
23e0a4e
@noroadsleft
add LAYOUT_tkl_iso_tsangan_split_bs_rshift
affc79b
@noroadsleft
add LAYOUT_tkl_iso_tsangan
2e6e60d
@noroadsleft
enable Community Layout support
28c5348
@noroadsleft noroadsleft requested a review from a team May 14, 2023 09:59
@noroadsleft noroadsleft merged commit a5b382b into qmk:develop May 14, 2023
@noroadsleft noroadsleft deleted the kb_layouts/4pplet_waffling80 branch May 14, 2023 19:52
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
4pplet Waffling80 Community Layout Support and Touch-Up (qmk#20932)
91c82d8 
* add matrix_diagram.md

* fix Configurator key sequence

* info.json: apply friendly formatting

* create common info.json

Moves the data-driven keys which are common between Rev A and Rev B to a joint `info.json` file.

* add LAYOUT_tkl_f13_ansi_split_space_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_split_bs_rshift

* add LAYOUT_tkl_f13_ansi

* add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_tsangan

* add LAYOUT_tkl_ansi_split_bs_rshift

* add LAYOUT_tkl_ansi

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_f13_iso_split_space_split_bs_rshift

* add LAYOUT_tkl_f13_iso_split_bs_rshift

* add LAYOUT_tkl_f13_iso

* add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_f13_iso_tsangan

* add LAYOUT_tkl_iso_split_bs_rshift

* add LAYOUT_tkl_iso

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
4pplet Waffling80 Community Layout Support and Touch-Up (qmk#20932)
7937a87 
* add matrix_diagram.md

* fix Configurator key sequence

* info.json: apply friendly formatting

* create common info.json

Moves the data-driven keys which are common between Rev A and Rev B to a joint `info.json` file.

* add LAYOUT_tkl_f13_ansi_split_space_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_split_bs_rshift

* add LAYOUT_tkl_f13_ansi

* add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_tsangan

* add LAYOUT_tkl_ansi_split_bs_rshift

* add LAYOUT_tkl_ansi

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_f13_iso_split_space_split_bs_rshift

* add LAYOUT_tkl_f13_iso_split_bs_rshift

* add LAYOUT_tkl_f13_iso

* add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_f13_iso_tsangan

* add LAYOUT_tkl_iso_split_bs_rshift

* add LAYOUT_tkl_iso

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark