Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend ryanbaekr boards by pin definitions #21248

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jun 14, 2023

Description

During creation of a now closed PR, noticed a section of ryanbaekr boards that define elite_c pins but have defined "promicro" as their controller. This PR aims to amend this configuration mismatch by changing processor, bootloader, and pin_compatibility to elite_c.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team June 15, 2023 03:49
@drashna drashna merged commit 1339b76 into qmk:develop Jul 3, 2023
@dunk2k dunk2k deleted the rynbkr branch August 18, 2023 20:33
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants