Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Make changes to some pins #21380

Merged
merged 11 commits into from
Sep 6, 2023
Merged

[Refactor] Make changes to some pins #21380

merged 11 commits into from
Sep 6, 2023

Conversation

ctt-t
Copy link
Contributor

@ctt-t ctt-t commented Jun 25, 2023 •
edited
Loading

Description

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 25, 2023
lesshonor
lesshonor suggested changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this keyboard released? If there are PCBs made with the old pin definitions, they will not work with this change and you should create a new revision of the keyboard.

keyboards/citrus/erdnuss65/info.json Show resolved Hide resolved
@ctt-t ctt-t requested a review from lesshonor July 12, 2023 10:19
lesshonor
lesshonor suggested changes Jul 12, 2023
View reviewed changes
keyboards/citrus/erdnuss65/info.json Outdated Show resolved Hide resolved
keyboards/citrus/erdnuss65/info.json Outdated Show resolved Hide resolved
@ctt-t
Copy link
Contributor Author

ctt-t commented Aug 8, 2023

When can this be merge pull requests

@drashna drashna requested a review from a team August 14, 2023 06:55
@ctt-t ctt-t requested a review from lesshonor September 6, 2023 01:51
@fauxpark fauxpark merged commit 32c90bf into qmk:develop Sep 6, 2023
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@ctt-t @mechlovin
[Refactor] Make changes to some pins (qmk#21380)
bc341bf
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@ctt-t @zgagnon
[Refactor] Make changes to some pins (qmk#21380)
1cccb6f
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@ctt-t
[Refactor] Make changes to some pins (qmk#21380)
91e9031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctt-t @drashna @fauxpark @lesshonor