Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of USB_LED_NUM_LOCK #21424

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Get rid of USB_LED_NUM_LOCK #21424

merged 2 commits into from
Jul 2, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 2, 2023

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 2, 2023 00:38
@zvecr zvecr merged commit 9ab16e6 into qmk:develop Jul 2, 2023
@fauxpark fauxpark deleted the remove-num-lock-define branch July 2, 2023 22:37
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
Get rid of USB_LED_NUM_LOCK (qmk#21424)
4789ae7
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
Get rid of USB_LED_NUM_LOCK (qmk#21424)
cfd815b
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
Get rid of USB_LED_NUM_LOCK (qmk#21424)
cb1bd2a
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
Get rid of USB_LED_NUM_LOCK (qmk#21424)
c1d0195
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@fauxpark @jashort
Get rid of USB_LED_NUM_LOCK (qmk#21424)
b2d4fbf
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
Get rid of USB_LED_NUM_LOCK (qmk#21424)
f938fca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @nooges @zvecr