Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor capsunlocked/cu80/v2 #21454

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Refactor capsunlocked/cu80/v2 #21454

merged 2 commits into from
Jul 7, 2023

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Jul 5, 2023

Description

Remove v2_ansi/v2_iso directories and move to single v2 folder with subdirectories, since only difference is layout and RGB Matrix data.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 5, 2023
@dunk2k
Copy link
Contributor

dunk2k commented Jul 5, 2023 •
edited
Loading

Nothing wrong with a good (h')optimisation.

As v2 directory can be complied, could you copy out the contents of v2/rules.mk into v2/ansi/rules.mk and v2/ansi/rules.mk?

@waffle87
Copy link
Member Author

waffle87 commented Jul 5, 2023

Nothing wrong with a good (h')optimisation.

As v2 directory can be complied, could you copy out the contents of v2/rules.mk into v2/ansi/rules.mk and v2/ansi/rules.mk?

Fixed in 321a345, but unsure why it's not being reflected in PR link.

@drashna drashna requested a review from a team July 6, 2023 05:10
@fauxpark fauxpark merged commit 98b438d into qmk:develop Jul 7, 2023
@waffle87 waffle87 deleted the fix/cu80 branch July 10, 2023 02:33
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@waffle87 @jesperhellberg
Refactor capsunlocked/cu80/v2 (qmk#21454)
19f4496
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@waffle87 @thismarvin
Refactor capsunlocked/cu80/v2 (qmk#21454)
06c7599
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@waffle87 @akeep
Refactor capsunlocked/cu80/v2 (qmk#21454)
1045a6a
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@waffle87 @csolje
Refactor capsunlocked/cu80/v2 (qmk#21454)
327015f
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@waffle87 @autoferrit
Refactor capsunlocked/cu80/v2 (qmk#21454)
2c388db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waffle87 @dunk2k @drashna @fauxpark