Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process_keycode: remove direct quantum.h includes #21486

Merged
merged 6 commits into from
Jul 11, 2023
Merged

process_keycode: remove direct quantum.h includes #21486

merged 6 commits into from
Jul 11, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 9, 2023 •
edited
Loading

Description

This one might throw up a ton of errors...I test compiled a few features though.
Some of them had to be kept/moved as there were references to stuff that is actually declared in quantum.h.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 9, 2023 06:13
@drashna drashna requested a review from a team July 11, 2023 06:57
@fauxpark fauxpark merged commit eee0384 into qmk:develop Jul 11, 2023
@fauxpark fauxpark deleted the process-keycode-remove-quantum-include branch July 11, 2023 07:07
@filterpaper filterpaper mentioned this pull request Jul 12, 2023
Merged
14 tasks
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
process_keycode: remove direct quantum.h includes (qmk#21486)
e6b2e30
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
process_keycode: remove direct quantum.h includes (qmk#21486)
fcac47f
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
process_keycode: remove direct quantum.h includes (qmk#21486)
81b8f6c
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
process_keycode: remove direct quantum.h includes (qmk#21486)
3c61803
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
process_keycode: remove direct quantum.h includes (qmk#21486)
665091f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna