Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leeloo revision 2 updates. #21671

Merged
merged 22 commits into from
Oct 5, 2023
Merged

Leeloo revision 2 updates. #21671

merged 22 commits into from
Oct 5, 2023

Conversation

ClicketySplit
Copy link
Contributor

@ClicketySplit ClicketySplit commented Aug 2, 2023 •
edited
Loading

Description

Adding revision 2 updates and transitioning towards data driven keyboard configuration—info.json.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Moved features to info.json.
  • Removed unnecessary files.
  • Simplified keymap.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dunk2k
dunk2k suggested changes Aug 2, 2023
View reviewed changes
keyboards/clickety_split/leeloo/info.json Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rules.mk Show resolved Hide resolved
drashna
drashna requested changes Aug 2, 2023
View reviewed changes
keyboards/clickety_split/leeloo/readme.md Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/readme.md Outdated Show resolved Hide resolved
@ClicketySplit ClicketySplit requested a review from drashna August 2, 2023 20:05
zvecr
zvecr requested changes Aug 3, 2023
View reviewed changes
keyboards/clickety_split/leeloo/leeloo.h Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/leeloo.c Outdated Show resolved Hide resolved
@ClicketySplit ClicketySplit requested a review from zvecr August 3, 2023 14:22
@github-actions github-actions bot added core via Adds via keymap and/or updates keyboard for via support labels Sep 1, 2023
@drashna
Copy link
Member

drashna commented Sep 3, 2023

You have some additional commits here that shouldn't be here. It looks like you may have botched a merge. Rebasing may help with this.

ClicketySplit and others added 9 commits September 3, 2023 03:30
@ClicketySplit
Leeloo revision 2 updates.
34868e3
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/info.json
93da0bb 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit
Base features to info.json and rgb feature to r2.
4f672f2
@ClicketySplit @drashna
Update keyboards/clickety_split/leeloo/readme.md
8791f69 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@ClicketySplit @drashna
Update keyboards/clickety_split/leeloo/readme.md
ae4c9dc 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@ClicketySplit @zvecr
Update keyboards/clickety_split/leeloo/leeloo.c
9ce617d 
Co-authored-by: Joel Challis <git@zvecr.com>
@ClicketySplit @zvecr
Update keyboards/clickety_split/leeloo/rev1/rules.mk
e79d51f 
Co-authored-by: Joel Challis <git@zvecr.com>
@ClicketySplit @zvecr
Update keyboards/clickety_split/leeloo/rev2/rules.mk
e7c22e3 
Co-authored-by: Joel Challis <git@zvecr.com>
@ClicketySplit
Removed unecessary files and condition statement.
9b5b6c1
@github-actions github-actions bot removed core via Adds via keymap and/or updates keyboard for via support labels Sep 3, 2023
@ClicketySplit
Copy link
Contributor Author

ClicketySplit commented Sep 3, 2023 •
edited
Loading

You have some additional commits here that shouldn't be here. It looks like you may have botched a merge. Rebasing may help with this.

Thank you @drashna! Hopefully I did it right this time; it looks like the checks have passed. :)

@drashna drashna requested a review from a team September 15, 2023 19:36
ClicketySplit and others added 3 commits September 17, 2023 11:24
@ClicketySplit @fauxpark
Update keyboards/clickety_split/leeloo/keymaps/default/config.h
931ce8e 
Co-authored-by: Ryan <fauxpark@gmail.com>
@ClicketySplit @fauxpark
Update keyboards/clickety_split/leeloo/keymaps/default/config.h
291aa00 
Co-authored-by: Ryan <fauxpark@gmail.com>
@ClicketySplit @fauxpark
Update keyboards/clickety_split/leeloo/rev2/config.h
c4052e0 
Co-authored-by: Ryan <fauxpark@gmail.com>
@ClicketySplit
Copy link
Contributor Author

Hi @fauxpark!

Thank you for the recommendations.

:)

dunk2k
dunk2k suggested changes Oct 2, 2023
View reviewed changes
keyboards/clickety_split/leeloo/rev1/info.json Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev2/info.json Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev2/config.h Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/leeloo.c Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/info.json Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rules.mk Outdated Show resolved Hide resolved
keyboards/clickety_split/leeloo/rev2/rules.mk Outdated Show resolved Hide resolved
ClicketySplit and others added 9 commits October 2, 2023 10:33
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/rev2/rules.mk
cf41989 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/rules.mk
6345425 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/info.json
b847615 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/keymaps/default/keymap.c
1c46411 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/keymaps/default/config.h
5b2c02f 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/leeloo.c
ce1a9dc 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/rev2/config.h
6873be1 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/rev2/info.json
9162534 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@ClicketySplit @dunk2k
Update keyboards/clickety_split/leeloo/rev1/info.json
829248d 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@drashna drashna merged commit d187a0a into qmk:develop Oct 5, 2023
3 checks passed
@ClicketySplit ClicketySplit deleted the leeloo_rev2 branch October 8, 2023 05:45
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@ClicketySplit @dunk2k
@drashna @zvecr @fauxpark @mechlovin
Leeloo revision 2 updates (qmk#21671)
5041c3c 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@ClicketySplit @dunk2k
@drashna @zvecr @fauxpark @christrotter
Leeloo revision 2 updates (qmk#21671)
46611ee 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@ClicketySplit @dunk2k
@drashna @zvecr @fauxpark @zgagnon
Leeloo revision 2 updates (qmk#21671)
a724305 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@ClicketySplit @dunk2k
@drashna @zvecr @fauxpark
Leeloo revision 2 updates (qmk#21671)
cd8e177 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@ClicketySplit @dunk2k
@drashna @zvecr @fauxpark
Leeloo revision 2 updates (qmk#21671)
f3200c9 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ClicketySplit @drashna @fauxpark @zvecr @dunk2k