Add Qk100 Keyboard files #21782
Merged
Add Qk100 Keyboard files #21782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
waffle87
requested changes
Aug 19, 2023
|
It would also be preferable to condense the duplicated code, such as qk100
├── ansi
│ └── info.json # ansi specific configuration
├── info.json # configuration that applies to both pcbs
├── ld
├── qk100.c
├── rules.mk
└── solder
└── info.json # solder specific configuration |
7 tasks
|
Bump |
drashna
requested changes
Aug 24, 2023
keyboards/qwertykeys/qk100/ld/STM32F103x8_0x08006000_bootloader.ld
Outdated
Show resolved
Hide resolved
drashna
requested changes
Aug 26, 2023
Comment on lines
42
to
43
| # define RGB_MATRIX_DISABLE_KEYCODES | ||
| # define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects |
There was a problem hiding this comment.
setting the disable after timeout to 0 disables it, so there is no point in having it defined as 0.
Additionally, the rgb keycodes shouldn't be using the function keys, but should be using custom keycodes. (eg QK_KB-QK_KB_MAX)
|
@drashna Thank you so much for your great advice. |
|
Bump |
drashna
requested changes
Aug 30, 2023
drashna
requested changes
Aug 30, 2023
|
Hi, Please check. Thank you for your time |
drashna
approved these changes
Sep 1, 2023
|
Bump |
|
Hello. Are there any further issues with merge? |
drashna
reviewed
Sep 23, 2023
drashna
requested changes
Sep 23, 2023
drashna
reviewed
Sep 25, 2023
drashna
approved these changes
Sep 25, 2023
|
Please Check for merge. |
|
Bump |
|
Please check, thanks. |
waffle87
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist