Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is31fl3741: Allow changing config register #21861

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

JohnAZoidberg
Copy link
Contributor

@JohnAZoidberg JohnAZoidberg commented Aug 29, 2023

Description

The documentation says this is possible but this driver has it hardcoded.

When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise.
This is done by changing the config register.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

When not all SW pins are used, it's useful to disable those that aren't.
Can reduce audible noise.

```
Layout:
D7:D4 D3  D2:D1 D0
SWD   LGC OSDE  SSD

SWS: SWx Setting. Change how many SW pins are active
LGC: H/L Logic
SSD: Software Shutdown Control
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@github-actions github-actions bot added the core label Aug 29, 2023
@drashna drashna changed the base branch from master to develop August 30, 2023 00:04
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be set to target develop. (and have done so)

@drashna drashna requested review from drashna and a team August 30, 2023 00:06
@zvecr zvecr merged commit 367b8e0 into qmk:develop Aug 31, 2023
1 check failed
dunk2k pushed a commit to dunk2k/qmk_firmware that referenced this pull request Sep 5, 2023
When not all SW pins are used, it's useful to disable those that aren't.
Can reduce audible noise.

```
Layout:
D7:D4 D3  D2:D1 D0
SWD   LGC OSDE  SSD

SWS: SWx Setting. Change how many SW pins are active
LGC: H/L Logic
SSD: Software Shutdown Control
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
When not all SW pins are used, it's useful to disable those that aren't.
Can reduce audible noise.

```
Layout:
D7:D4 D3  D2:D1 D0
SWD   LGC OSDE  SSD

SWS: SWx Setting. Change how many SW pins are active
LGC: H/L Logic
SSD: Software Shutdown Control
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
When not all SW pins are used, it's useful to disable those that aren't.
Can reduce audible noise.

```
Layout:
D7:D4 D3  D2:D1 D0
SWD   LGC OSDE  SSD

SWS: SWx Setting. Change how many SW pins are active
LGC: H/L Logic
SSD: Software Shutdown Control
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
When not all SW pins are used, it's useful to disable those that aren't.
Can reduce audible noise.

```
Layout:
D7:D4 D3  D2:D1 D0
SWD   LGC OSDE  SSD

SWS: SWx Setting. Change how many SW pins are active
LGC: H/L Logic
SSD: Software Shutdown Control
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants