-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is31fl3741: Allow changing config register #21861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise. ``` Layout: D7:D4 D3 D2:D1 D0 SWD LGC OSDE SSD SWS: SWx Setting. Change how many SW pins are active LGC: H/L Logic SSD: Software Shutdown Control ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
drashna
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be set to target develop. (and have done so)
fauxpark
approved these changes
Aug 31, 2023
zvecr
approved these changes
Aug 31, 2023
dunk2k
pushed a commit
to dunk2k/qmk_firmware
that referenced
this pull request
Sep 5, 2023
When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise. ``` Layout: D7:D4 D3 D2:D1 D0 SWD LGC OSDE SSD SWS: SWx Setting. Change how many SW pins are active LGC: H/L Logic SSD: Software Shutdown Control ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise. ``` Layout: D7:D4 D3 D2:D1 D0 SWD LGC OSDE SSD SWS: SWx Setting. Change how many SW pins are active LGC: H/L Logic SSD: Software Shutdown Control ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise. ``` Layout: D7:D4 D3 D2:D1 D0 SWD LGC OSDE SSD SWS: SWx Setting. Change how many SW pins are active LGC: H/L Logic SSD: Software Shutdown Control ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise. ``` Layout: D7:D4 D3 D2:D1 D0 SWD LGC OSDE SSD SWS: SWx Setting. Change how many SW pins are active LGC: H/L Logic SSD: Software Shutdown Control ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation says this is possible but this driver has it hardcoded.
When not all SW pins are used, it's useful to disable those that aren't. Can reduce audible noise.
This is done by changing the config register.
Types of Changes
Checklist