Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: joystick weights #21883

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Feature: joystick weights #21883

merged 4 commits into from
Dec 1, 2023

Conversation

daliusd
Copy link
Contributor

@daliusd daliusd commented Sep 1, 2023

Joystick weights.

Description

I have played around with different algorithms how joystick should work and found out that default x^2 weighting is not necessary optimal. Therefore I have added possibility for user to override weighting for lever positions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@daliusd
Copy link
Contributor Author

daliusd commented Sep 1, 2023

Here I have written blog post how I came up with this: https://blog.ffff.lt/posts/joystick-algorithms/

@zvecr zvecr changed the base branch from master to develop September 1, 2023 15:11
@drashna drashna requested review from drashna and a team September 1, 2023 20:19
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have any joysticks so can't test, but I don't see anything of concern here.

@noroadsleft noroadsleft requested a review from a team October 9, 2023 06:39
drashna
drashna previously approved these changes Oct 13, 2023
@drashna drashna requested a review from a team October 13, 2023 05:13
@daliusd
Copy link
Contributor Author

daliusd commented Nov 3, 2023

Hey, I have two more changes related with analog joystick, but they are kind of related to this one: automatically resolving min/max axis values and one change that makes joystick behave slightly differently. Should I wait until this PR gets merged or there are other options? cc: @drashna

@drashna
Copy link
Member

drashna commented Nov 8, 2023

Hey, I have two more changes related with analog joystick, but they are kind of related to this one: automatically resolving min/max axis values and one change that makes joystick behave slightly differently. Should I wait until this PR gets merged or there are other options? cc: @drashna

That entirely depends on you. Adding more to it would mean that it's definitely gonna be longer to get approved. But it's merge month, so ... it may not make it anyways. So it's up to you.

That said, if this is all for joystick code, I'd say roll it into this PR.

@daliusd
Copy link
Contributor Author

daliusd commented Nov 9, 2023

Hey, I have added two more features to joystick code. Please review again.

@tzarc tzarc requested a review from a team November 26, 2023 11:47
@tzarc tzarc dismissed drashna’s stale review November 26, 2023 11:47

Was re-requested by submitter.

@drashna drashna merged commit cc3c3ac into qmk:develop Dec 1, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
Co-authored-by: Nick Brassel <nick@tzarc.org>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
Co-authored-by: Nick Brassel <nick@tzarc.org>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
Co-authored-by: Nick Brassel <nick@tzarc.org>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants