Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RP2040 support for apa102 RGB LED driver #21908

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 5, 2023

Description

Not sure if this is the best way to handle this... but I can confirm that it does work. (tested on micromod "input and display" carrier board, with RP2040 processor board)

Types of Changes

  • Core

Issues Fixed or Closed by This PR

  • Compilation issue when testing

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from fauxpark, KarlK90 and a team September 5, 2023 01:50
@github-actions github-actions bot added the core label Sep 5, 2023
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@KarlK90 KarlK90 merged commit 9d4347b into qmk:develop Sep 6, 2023
3 checks passed
@drashna drashna deleted the apa102_rp2040 branch September 7, 2023 09:34
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants