Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RGB matrix & LED Matrix support for IS31FL3729 #21944

Merged
merged 26 commits into from
Feb 16, 2024
Merged

Add RGB matrix & LED Matrix support for IS31FL3729 #21944

merged 26 commits into from
Feb 16, 2024

Conversation

HorrorTroll
Copy link
Contributor

Description

Added support IS31FL3729 LED driver for both RGB Matrix and LED Matrix, was tested and work perfectly on my board. Updated docs with how to configure new features.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dexter93
Copy link
Contributor

dexter93 commented Sep 7, 2023

needs formatting to pass lint

@HorrorTroll
Copy link
Contributor Author

needs formatting to pass lint

Thanks for review, I've just redone formatting lint

@HorrorTroll HorrorTroll force-pushed the is31fl3729 branch 4 times, most recently from bf9cf29 to 26087c5 Compare September 23, 2023 09:41
fauxpark
fauxpark requested changes Sep 23, 2023
View reviewed changes
builddefs/common_features.mk Outdated Show resolved Hide resolved
builddefs/common_features.mk Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.h Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.h Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.h Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
@HorrorTroll
Copy link
Contributor Author

Thanks for review, fauxpark. I've just push a new commit to resolve your suggested.

@Xelus22 Xelus22 mentioned this pull request Oct 1, 2023
Closed
14 tasks
Xelus22
Xelus22 reviewed Oct 11, 2023
View reviewed changes
docs/feature_led_matrix.md Outdated Show resolved Hide resolved
@fauxpark fauxpark self-assigned this Oct 11, 2023
@HorrorTroll
Copy link
Contributor Author

I've just resolve conflicted issue. Can i have another review on this PR? Thanks

@drashna drashna requested review from a team and removed request for Xelus22 November 8, 2023 06:02
zvecr
zvecr requested changes Dec 4, 2023
View reviewed changes
docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
docs/feature_led_matrix.md Outdated Show resolved Hide resolved
docs/feature_led_matrix.md Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.h Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.h Show resolved Hide resolved
fauxpark
fauxpark requested changes Dec 6, 2023
View reviewed changes
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
@HorrorTroll
Copy link
Contributor Author

I've just resolved issues. Can i have another review on this PR? Thanks!

fauxpark
fauxpark requested changes Dec 13, 2023
View reviewed changes
drivers/led/issi/is31fl3729.h Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.h Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-simple.c Outdated Show resolved Hide resolved
dexter93 and others added 20 commits February 13, 2024 16:09
fauxpark
fauxpark requested changes Feb 14, 2024
View reviewed changes
drivers/led/issi/is31fl3729-mono.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-mono.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-mono.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-mono.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729-mono.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
drivers/led/issi/is31fl3729.c Outdated Show resolved Hide resolved
fauxpark
fauxpark approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some work that needs doing to be in sync with the other drivers (particularly #22975) but I think it's time to just get this merged; I can sort that out + other cleanups in a followup PR.

@tzarc tzarc merged commit f6709e6 into qmk:develop Feb 16, 2024
4 checks passed
@HorrorTroll HorrorTroll deleted the is31fl3729 branch February 17, 2024 08:54
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@HorrorTroll @Xelus22
@dexter93 @nuess0r
Add RGB matrix & LED Matrix support for IS31FL3729 (qmk#21944)
f7cdc4d 
Co-authored-by: Xelus22 <preyas22@gmail.com>
Co-authored-by: dexter93 <d3xter93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 left review comments

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@dexter93 dexter93 dexter93 approved these changes

Assignees

@fauxpark fauxpark

Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HorrorTroll @dexter93 @drashna @fauxpark @zvecr @Xelus22 @tzarc