Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate keymap.json config options more forcefully #21960

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Generate keymap.json config options more forcefully #21960

merged 1 commit into from
Sep 13, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 9, 2023 •
edited
Loading

Description

Changes keymap level generation from:

#ifndef BOOTMAGIC_LITE_COLUMN
#    define BOOTMAGIC_LITE_COLUMN 1
#endif // BOOTMAGIC_LITE_COLUMN
BOOTLOADER ?= qmk-dfu

to

#undef BOOTMAGIC_LITE_COLUMN
#define BOOTMAGIC_LITE_COLUMN 1
BOOTLOADER = qmk-dfu

This should ensure that configuration gets correctly applied.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Sep 9, 2023
@zvecr zvecr mentioned this pull request Sep 9, 2023
Closed
2 tasks
@zvecr zvecr marked this pull request as ready for review September 9, 2023 07:05
@zvecr zvecr merged commit de381ad into develop Sep 13, 2023
6 checks passed
@zvecr zvecr deleted the fix_21958 branch September 13, 2023 00:12
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@zvecr @mechlovin
Generate keymap.json config options more forcefully (qmk#21960)
d475a69
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@zvecr @christrotter
Generate keymap.json config options more forcefully (qmk#21960)
e17e57a
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@zvecr @zgagnon
Generate keymap.json config options more forcefully (qmk#21960)
206e074
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@zvecr
Generate keymap.json config options more forcefully (qmk#21960)
ed38588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc