Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CKLED2001 driver to SNLED27351 #22071

Merged
merged 15 commits into from
Oct 4, 2023
Merged

Rename CKLED2001 driver to SNLED27351 #22071

merged 15 commits into from
Oct 4, 2023

Conversation

fauxpark
Copy link
Member

Description

SNLED27351 is the "true" name of this driver: https://www.sonix.com.tw/article-en-4678-39401

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 19, 2023 10:49
zvecr
zvecr reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not looked at keyboard changes, but non keyboard changes look good.

@Xelus22 Xelus22 mentioned this pull request Oct 1, 2023
Closed
14 tasks
@fauxpark fauxpark merged commit c0f16be into qmk:develop Oct 4, 2023
4 of 5 checks passed
@fauxpark fauxpark deleted the snled27351 branch October 4, 2023 09:10
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@fauxpark @mechlovin
Rename CKLED2001 driver to SNLED27351 (qmk#22071)
47a5fd7
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@fauxpark @christrotter
Rename CKLED2001 driver to SNLED27351 (qmk#22071)
1e78921
@vinorodrigues vinorodrigues mentioned this pull request Dec 13, 2023
Closed
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@fauxpark @zgagnon
Rename CKLED2001 driver to SNLED27351 (qmk#22071)
6984524
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@fauxpark
Rename CKLED2001 driver to SNLED27351 (qmk#22071)
bafe0c1
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@fauxpark
Rename CKLED2001 driver to SNLED27351 (qmk#22071)
fab171d
almaqyn pushed a commit to almaqyn/qmk_firmware that referenced this pull request Aug 16, 2024
@fauxpark @almaqyn
Rename CKLED2001 driver to SNLED27351 (qmk#22071)
10c2ec8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @tzarc @zvecr