Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dp3000 rev2 featuring rgblight #22084

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

depermana12
Copy link
Contributor

Description

  • Moved the original files to rev1 folder, featuring rgb_matrix
  • Adding rev2 with different pid, featuring rgblight

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@depermana12
Copy link
Contributor Author

Hi @drashna @fauxpark, I apologize for closing the previous PR #21478, due to a merging mistake. Unfortunately, I made another mistake by executing git reset --hard, which prevented me from reopening it. I decided to remove the branch and create this new PR. I'd greatly appreciate your review.

@drashna drashna requested a review from a team September 23, 2023 06:01
@drashna drashna merged commit b667408 into qmk:develop Sep 24, 2023
3 checks passed
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants