Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ALLOW_WARNINGS and PICO_INTRINSICS_ENABLED #22085

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Remove ALLOW_WARNINGS and PICO_INTRINSICS_ENABLED #22085

merged 1 commit into from
Sep 20, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 20, 2023 •
edited
Loading

Description

Neither should be set, especially ALLOW_WARNINGS as that will mask non rp2040 specific issues.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team September 20, 2023 08:42
@zvecr zvecr merged commit f03c470 into develop Sep 20, 2023
3 checks passed
@zvecr zvecr deleted the rm_rp2040_bodges branch September 20, 2023 09:27
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@zvecr @mechlovin
Remove ALLOW_WARNINGS and PICO_INTRINSICS_ENABLED (qmk#22085)
2d92476
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@zvecr @christrotter
Remove ALLOW_WARNINGS and PICO_INTRINSICS_ENABLED (qmk#22085)
2c008f3
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@zvecr @zgagnon
Remove ALLOW_WARNINGS and PICO_INTRINSICS_ENABLED (qmk#22085)
fa0a52f
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@zvecr
Remove ALLOW_WARNINGS and PICO_INTRINSICS_ENABLED (qmk#22085)
a844df2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark