[QP] Color inversion control functions. #22098
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This has two main goals:
Instead of overriding it (
__weak__
function) with the command flipped... Just call these functions.qp_comms.h
functions from user code)To avoid code duplication (eg all ili9xxx use the same pair of commands), i've added files for family-specific logic. As a bonus, since that needed to check "is this family of devices enabled?",
mk
logic was partly rewritten, reducing duplication.As discussed on Discord, even tho this "bloats" the amount of functions, it is (for now?) preferred over adding it to the standarized API because some devices wouldnt be able to support it.
Extra: Took the chance to remove
!= NULL
checks from docs, since #20481 added those to the core code and users dont need them anymore.Types of Changes
Issues Fixed or Closed by This PR
Checklist