Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated rgblight implementation from mxss #22122

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Remove duplicated rgblight implementation from mxss #22122

merged 1 commit into from
Sep 25, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 24, 2023 •
edited
Loading

Description

In the same vein as 22073. If someone has one and wants to reimplement using something like rgblight layers or rgblight_call_driver, they are free to do so.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 24, 2023
@tzarc tzarc merged commit a4760c4 into develop Sep 25, 2023
3 checks passed
@tzarc tzarc deleted the rm_mxss_rgblight branch September 25, 2023 03:04
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@zvecr @mechlovin
Remove duplicated rgblight implementation from mxss (qmk#22122)
bb3fa55
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@zvecr @christrotter
Remove duplicated rgblight implementation from mxss (qmk#22122)
e47c5f8
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@zvecr @zgagnon
Remove duplicated rgblight implementation from mxss (qmk#22122)
c3ff6e8
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@zvecr
Remove duplicated rgblight implementation from mxss (qmk#22122)
116ab48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark