Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move velocikey to within rgblight #22123

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Move velocikey to within rgblight #22123

merged 1 commit into from
Sep 25, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 24, 2023 •
edited
Loading

Description

  • Low use feature that is currently coupled only to rgblight
  • Free up u8 of eeprom
  • Should really be implemented with WPM feature, and for other lighting systems

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review September 25, 2023 08:55
@zvecr zvecr merged commit 339bff6 into develop Sep 25, 2023
5 checks passed
@zvecr zvecr deleted the mv_velocikey branch September 25, 2023 16:48
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@zvecr @mechlovin
Move velocikey to within rgblight (qmk#22123)
3d93a73
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@zvecr @christrotter
Move velocikey to within rgblight (qmk#22123)
6e2e64a
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@zvecr @zgagnon
Move velocikey to within rgblight (qmk#22123)
b524cb7
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@zvecr
Move velocikey to within rgblight (qmk#22123)
8dcd35c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc