KC60 Layout Standardization and Cleanup #22125

noroadsleft · 2023-09-24T08:43:36Z

Description

This should more or less complete the layout support for the KC60.

Touch-up default and via keymaps
Refactor user keymaps
All the keymaps in question were using the LAYOUT macro, which did not conform to QMK's standards.
Remove LAYOUT macro
Add nine new layouts
Add layout/matrix diagram

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- use `layer_names` enum - use QMK-native alias for `KC_TRNS` - apply four-space indent - grid-align keycodes - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor]

- fix keycode grid alignment [style]

- grid-align keycodes - apply four-space indent - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor]

- delete `config.h` (use RGB config from keyboard `info.json`) - fixes non-compilation - use `layer_names` enum - use four-space indent - update keycode grid alignment - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [bugfix] [refactor]

- fix keycode grid alignment [style]

- use four-space indent - use QMK-native keycode alias for `KC_DELETE` - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor]

Superseded by `LAYOUT_all`. [chore]

[enhancement]

[docs]

dunk2k · 2023-09-24T12:43:48Z

@noroadsleft
psssst, you forgot to add community_layouts in info.json 🙊

P.S. have done that a few times myself in my recent rampage(s) on community layouts 😉

[enhancement]

Add support for community layouts: - `60_ansi_split_bs_rshift` - `60_ansi_tsangan` - `60_tsangan_hhkb` - `60_hhkb` - `60_abnt2` - `60_iso` - `60_iso_split_bs_rshift` - `60_iso_tsangan` [enhancement]

[bugfix]

* Refactor `dbroqua` keymap - use `layer_names` enum - use QMK-native alias for `KC_TRNS` - apply four-space indent - grid-align keycodes - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor] * Refactor `dbroqua_hhkb` keymap - use `layer_names` enum - use QMK-native alias for `KC_TRNS` - apply four-space indent - grid-align keycodes - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor] * Touch-up `default` keymap - fix keycode grid alignment [style] * Refactor `sgoodwin` keymap - grid-align keycodes - apply four-space indent - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor] * Refactor `stanleylai` keymap - delete `config.h` (use RGB config from keyboard `info.json`) - fixes non-compilation - use `layer_names` enum - use four-space indent - update keycode grid alignment - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [bugfix] [refactor] * Touch-up `via` keymap - fix keycode grid alignment [style] * Refactor `wigguno` keymap - use four-space indent - use QMK-native keycode alias for `KC_DELETE` - refactor keymap to use `LAYOUT_all` macro. - The keycode for position [4, 9] (right half of Split Backspace) moves to the top row. - The keycodes for positions [3, 12] and [3, 13] (1.75u/1u Split RShift) switch positions. [refactor] * Remove `LAYOUT` macro Superseded by `LAYOUT_all`. [chore] * Add `LAYOUT_60_ansi_split_bs_rshift` [enhancement] * Add `LAYOUT_60_tsangan_hhkb` [enhancement] * Add `LAYOUT_60_ansi_tsangan` [enhancement] * Add `LAYOUT_60_iso_split_bs_rshift` [enhancement] * Add `LAYOUT_60_iso` [enhancement] * Add `LAYOUT_60_iso_tsangan_split_bs_rshift` [enhancement] * Add `LAYOUT_60_iso_tsangan` [enhancement] * Add `LAYOUT_60_hhkb` [enhancement] * Add `LAYOUT_60_true_hhkb` [enhancement] * Add layout/matrix diagram [docs] * Add `LAYOUT_60_abnt2` [enhancement] * Extend Community Layout support Add support for community layouts: - `60_ansi_split_bs_rshift` - `60_ansi_tsangan` - `60_tsangan_hhkb` - `60_hhkb` - `60_abnt2` - `60_iso` - `60_iso_split_bs_rshift` - `60_iso_tsangan` [enhancement] * Fix `LAYOUT_60_abnt2` support [bugfix]

noroadsleft added 18 commits September 24, 2023 01:25

Touch-up default keymap

6d9a636

- fix keycode grid alignment [style]

Touch-up via keymap

08a5d71

- fix keycode grid alignment [style]

Remove LAYOUT macro

7cb36a5

Superseded by `LAYOUT_all`. [chore]

Add LAYOUT_60_ansi_split_bs_rshift

eaef678

[enhancement]

Add LAYOUT_60_tsangan_hhkb

b0438d4

[enhancement]

Add LAYOUT_60_ansi_tsangan

771b166

[enhancement]

Add LAYOUT_60_iso_split_bs_rshift

d699825

[enhancement]

Add LAYOUT_60_iso

0f9b408

[enhancement]

Add LAYOUT_60_iso_tsangan_split_bs_rshift

c8fb4bf

[enhancement]

Add LAYOUT_60_iso_tsangan

0baaf58

[enhancement]

Add LAYOUT_60_hhkb

dca709d

[enhancement]

Add LAYOUT_60_true_hhkb

f1aed32

[enhancement]

Add layout/matrix diagram

df5d1a4

[docs]

noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 24, 2023

noroadsleft requested a review from a team September 24, 2023 08:43

fauxpark approved these changes Sep 24, 2023

View reviewed changes

noroadsleft added 3 commits September 24, 2023 08:32

Add LAYOUT_60_abnt2

9ca8984

[enhancement]

Extend Community Layout support

a726375

Add support for community layouts: - `60_ansi_split_bs_rshift` - `60_ansi_tsangan` - `60_tsangan_hhkb` - `60_hhkb` - `60_abnt2` - `60_iso` - `60_iso_split_bs_rshift` - `60_iso_tsangan` [enhancement]

Fix LAYOUT_60_abnt2 support

5bcc015

[bugfix]

dunk2k approved these changes Sep 24, 2023

View reviewed changes

noroadsleft merged commit a692623 into qmk:develop Sep 24, 2023
1 of 3 checks passed

noroadsleft deleted the dev/kc60 branch September 24, 2023 22:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KC60 Layout Standardization and Cleanup #22125

KC60 Layout Standardization and Cleanup #22125

noroadsleft commented Sep 24, 2023

dunk2k commented Sep 24, 2023

KC60 Layout Standardization and Cleanup #22125

KC60 Layout Standardization and Cleanup #22125

Conversation

noroadsleft commented Sep 24, 2023

Description

Types of Changes

Checklist

dunk2k commented Sep 24, 2023