Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing/validation for 21939 #22148

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Fix parsing/validation for 21939 #22148

merged 3 commits into from
Sep 27, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 27, 2023

Description

  • incorrect jsonschema type for react_on_keyup
    • just wrong... will look at adding something in CI to try and stop this slipping through in the future
  • "value_type": "bool" currently does the wrong thing for parsing defines with no value
    • existing issue
    • #define FORCE_NKRO incorrectly becomes "force_nkro" :false
    • parse_config_h_file correctly parses to True bool -> _config_to_json then only checks for string values

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Sep 27, 2023
@zvecr zvecr requested a review from a team September 27, 2023 00:57
@github-actions github-actions bot added dd Data Driven Changes python cli qmk cli command labels Sep 27, 2023
@zvecr
Copy link
Member Author

zvecr commented Sep 27, 2023

Updated _config_to_json to just check for bools as true_values is used for rules.mk logic and wouldn't want to introduce issues in that pathway.

@zvecr zvecr requested review from fauxpark and a team September 27, 2023 02:53
@zvecr zvecr merged commit 4e86dca into develop Sep 27, 2023
4 of 5 checks passed
@zvecr zvecr deleted the 21939_fixes branch September 27, 2023 02:57
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command dd Data Driven Changes python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants