Fix memory leak in realloc failure handling #22188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
approved these changes
Oct 2, 2023
elpekenin
approved these changes
Oct 3, 2023
zvecr
reviewed
Oct 3, 2023
visitorckw
force-pushed
the
fix-memory-leak
branch
2 times, most recently
from
e07a269 to
14dce44
Compare
In the qp_lvgl_attach function, when reallocating memory for the color_buffer, we were not properly handling the case when realloc fails, leading to potential memory leaks. This change ensures that memory is properly managed, and potential memory leaks are prevented in the qp_lvgl_attach function.
visitorckw
force-pushed
the
fix-memory-leak
branch
from
14dce44 to
6c683cf
Compare
zvecr
approved these changes
Oct 3, 2023
tzarc
approved these changes
Oct 3, 2023
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
christrotter
pushed a commit
to christrotter/qmk_firmware
that referenced
this pull request
Nov 28, 2023
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
mute-civilian
pushed a commit
to mute-civilian/qmk_firmware
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the qp_lvgl_attach function, when reallocating memory for the color_buffer, we were not properly handling the case when realloc fails, leading to potential memory leaks. This change ensures that memory is properly managed, and potential memory leaks are prevented in the qp_lvgl_attach function.
Types of Changes
Issues Fixed or Closed by This PR
Checklist