Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zk3mod : added OLED #22303

Merged
merged 24 commits into from
Dec 12, 2023
Merged

zk3mod : added OLED #22303

merged 24 commits into from
Dec 12, 2023

Conversation

coomstoolbox
Copy link
Contributor

Description

Added oled variants.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 20, 2023
fauxpark
fauxpark requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates must go through develop.

waffle87
waffle87 requested changes Oct 22, 2023
View reviewed changes
keyboards/handwired/ziyoulang_k3_mod/info.json Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/info.json Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/ziyoulang_k3_mod_oled.c Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/ziyoulang_k3_mod_oled.c Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/ziyoulang_k3_mod_oled.c Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/ziyoulang_k3_mod_oled.c Outdated Show resolved Hide resolved
keyboards/handwired/ziyoulang_k3_mod/ziyoulang_k3_mod_oled.c Outdated Show resolved Hide resolved
@coomstoolbox
Copy link
Contributor Author

@waffle87
I appreciate the many confirmations.
I understand these and will fix them.

@coomstoolbox coomstoolbox changed the base branch from master to develop October 22, 2023 02:40
@coomstoolbox coomstoolbox mentioned this pull request Nov 18, 2023
Merged
7 tasks
@coomstoolbox
Copy link
Contributor Author

Is there any new code to correct? I would like to proceed to the next step if there are no problems.

@drashna drashna merged commit fb3c913 into qmk:develop Dec 12, 2023
3 checks passed
@coomstoolbox coomstoolbox deleted the z-k3-mod-oled4 branch December 12, 2023 13:15
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@coomstoolbox @waffle87
@fauxpark @itsjonny96
[Keyboard] zk3mod : added OLED (qmk#22303)
3585e4f 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@coomstoolbox @waffle87
@fauxpark @mechlovin
[Keyboard] zk3mod : added OLED (qmk#22303)
86f0097 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@coomstoolbox @waffle87
@fauxpark @mechlovin
[Keyboard] zk3mod : added OLED (qmk#22303)
3531496 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@coomstoolbox @waffle87
@fauxpark @nuess0r
[Keyboard] zk3mod : added OLED (qmk#22303)
775c547 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coomstoolbox @drashna @fauxpark @waffle87