Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5x13 and 6x13 ortho community layouts #22315

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Add 5x13 and 6x13 ortho community layouts #22315

merged 9 commits into from
Nov 29, 2023

Conversation

alinelena
Copy link
Contributor

@alinelena alinelena commented Oct 22, 2023 •
edited by zvecr
Loading

Description

Will also enable 5x13 and 6x13 ortho layouts as templates for new-keyboard.

Also fixes missing e in ortho 5x14 template.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot removed the keyboard label Oct 22, 2023
@alinelena alinelena marked this pull request as ready for review October 22, 2023 07:39
Alin Marin Elena and others added 3 commits October 22, 2023 08:55
@fauxpark
Update layouts/default/ortho_5x13/default_ortho_5x13/keymap.c
3aaaa45 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark
Update layouts/default/ortho_5x14/default_ortho_5x14/keymap.c
1b13bd4 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark
Update layouts/default/ortho_6x13/default_ortho_6x13/keymap.c
c915430 
Co-authored-by: Ryan <fauxpark@gmail.com>
@dunk2k
Copy link
Contributor

dunk2k commented Oct 22, 2023

Could respective entries be added into layouts/default/readme.md please?

@alinelena
Copy link
Contributor Author

Could respective entries be added into layouts/default/readme.md please?

done thank you!

dunk2k
dunk2k suggested changes Oct 22, 2023
View reviewed changes
layouts/default/readme.md Outdated Show resolved Hide resolved
@alinelena alinelena requested review from dunk2k and fauxpark October 22, 2023 14:37
@zvecr
Copy link
Member

zvecr commented Oct 22, 2023

add 5x13 and 6x13 ortho layouts in templates for new-keyboard

This is more a side effect of adding community layouts. There then is the question of if there is enough use within the repo for these to need to exist.

@zvecr zvecr changed the title add 5x13 and 6x13 ortho layouts in templates for new-keyboard Add 5x13 and 6x13 ortho community layouts Oct 22, 2023
@dunk2k
Copy link
Contributor

dunk2k commented Oct 24, 2023 •
edited
Loading

@alinelena

There then is the question of if there is enough use within the repo for these to need to exist.

Post-merge of this PR, would you be looking to append these community layouts to keyboards/ that match these layouts?

@alinelena
Copy link
Contributor Author

@dunk2k of course that was all the point in addition to have them in qmk new-keyboard

lesshonor
lesshonor approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@drashna drashna merged commit e3d367d into qmk:develop Nov 29, 2023
2 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@alinelena @fauxpark @itsjonny96
Add 5x13 and 6x13 ortho community layouts (qmk#22315)
6193773 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Alin Marin Elena <alin@elena.space>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@alinelena @fauxpark @mechlovin
Add 5x13 and 6x13 ortho community layouts (qmk#22315)
7323bad 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Alin Marin Elena <alin@elena.space>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@alinelena @fauxpark @mechlovin
Add 5x13 and 6x13 ortho community layouts (qmk#22315)
4e06e29 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Alin Marin Elena <alin@elena.space>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@alinelena @fauxpark @nuess0r
Add 5x13 and 6x13 ortho community layouts (qmk#22315)
317b035 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Alin Marin Elena <alin@elena.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor approved these changes

@dunk2k dunk2k dunk2k approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alinelena @dunk2k @zvecr @drashna @fauxpark @lesshonor