Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework RGBLight driver system #22529

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Rework RGBLight driver system #22529

merged 6 commits into from
Dec 5, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 22, 2023 •
edited
Loading

Description

Implemented rgblight_drivers.c in a similar fashion to LED/RGB Matrix, and updated affected keyboards accordingly.

The structure of rgblight_driver_t will change in the future to also match LED/RGB Matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 22, 2023 01:08
@fauxpark fauxpark mentioned this pull request Nov 22, 2023
Merged
14 tasks
@drashna drashna requested a review from a team November 29, 2023 02:15
@fauxpark fauxpark merged commit 17f36a2 into qmk:develop Dec 5, 2023
3 of 5 checks passed
@fauxpark fauxpark deleted the rgblight-drivers branch December 5, 2023 11:49
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
Rework RGBLight driver system (qmk#22529)
3b38e25
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
Rework RGBLight driver system (qmk#22529)
fb82222
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
Rework RGBLight driver system (qmk#22529)
9a39087
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Rework RGBLight driver system (qmk#22529)
8391c63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna