Add basic presence check for cirque trackpad. #22546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Nov 27, 2023
lesshonor
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
With this change my half-assembled Sugar Glider no longer activates the auto-mouse layer on boot. Very helpful. 🚀
zvecr
approved these changes
Dec 4, 2023
itsjonny96
pushed a commit
to itsjonny96/qmk_firmware
that referenced
this pull request
Jan 7, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 17, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 19, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just adds a simple check that the cirque trackpad is connected and working, not completely foolproof but better than how it behaves currently. This stops spurious inputs when SPI is reading random data due to a failed or incorrectly wired cirque.
We don't currently set a default ZIDLE value so seemed a good candidate for the check.
I've only got a SPI cirque from a steam controller to check this with so some feedback from other setups would be useful and appreciated.
I've added
CIRQUE_PINNACLE_SKIP_SENSOR_CHECKmostly for debugging purposes, the data sheet only specifies one default value but you never know.Types of Changes
Issues Fixed or Closed by This PR
Checklist