Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align VUSB suspend protocol logic #22688

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 17, 2023

Description

Partially restructures suspend (where possible) logic to LUFA/ChibiiOS while maintaining as much of the existing code as possible.

With the logic more uniform, it will facilitate changes such as #14944. Future iterations will head towards the eventual unification of suspend behaviour.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link

github-actions bot commented Feb 1, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 1, 2024
@zvecr zvecr added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Feb 1, 2024
@drashna drashna requested review from fauxpark and a team February 1, 2024 07:16
@zvecr zvecr merged commit 7902051 into qmk:develop Feb 1, 2024
4 checks passed
@zvecr zvecr deleted the align_vusb_suspend1 branch February 1, 2024 15:34
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants