Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect use of WS2812_PIO_USE_PIO1 #22771

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Remove incorrect use of WS2812_PIO_USE_PIO1 #22771

merged 1 commit into from
Dec 28, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 28, 2023 •
edited
Loading

Description

WS2812_PIO_USE_PIO1 should only be specified when there would be a conflict on PIO0.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 9e50fae into develop Dec 28, 2023
3 checks passed
@zvecr zvecr deleted the rm_ws2812_pio1 branch December 28, 2023 17:07
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@zvecr @itsjonny96
Remove incorrect use of WS2812_PIO_USE_PIO1 (qmk#22771)
3e8f4c3
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@zvecr @mechlovin
Remove incorrect use of WS2812_PIO_USE_PIO1 (qmk#22771)
b1c5498
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@zvecr @mechlovin
Remove incorrect use of WS2812_PIO_USE_PIO1 (qmk#22771)
0947687
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Remove incorrect use of WS2812_PIO_USE_PIO1 (qmk#22771)
aa80d9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @drashna