Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align SPLIT_HAND_MATRIX_GRID left/right logic with SPLIT_HAND_PIN #22775

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Align SPLIT_HAND_MATRIX_GRID left/right logic with SPLIT_HAND_PIN #22775

merged 1 commit into from
Jan 9, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 28, 2023 •
edited
Loading

Description

To make the eventual DD config more consistent, this PR changes SPLIT_HAND_MATRIX_GRID_LOW_IS_RIGHT to SPLIT_HAND_MATRIX_GRID_LOW_IS_LEFT matching SPLIT_HAND_PIN_LOW_IS_LEFT.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Align SPLIT_HAND_MATRIX_GRID_LOW_IS_RIGHT to SPLIT_HAND_PIN_LOW_IS_LEFT Align SPLIT_HAND_MATRIX_GRID left/right logic with SPLIT_HAND_PIN Dec 28, 2023
tzarc
tzarc approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA1s are all identical.

@tzarc tzarc merged commit ccec486 into develop Jan 9, 2024
4 of 5 checks passed
@tzarc tzarc deleted the invert_split_matrix_grid branch January 9, 2024 11:24
@zhyu zhyu mentioned this pull request Mar 4, 2024
Closed
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Align SPLIT_HAND_MATRIX_GRID left/right logic with SPLIT_HAND_PIN (…
8eccc21 
…qmk#22775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation keyboard translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc