Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IS31FLCOMMON code #22800

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Remove IS31FLCOMMON code #22800

merged 2 commits into from
Jan 2, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 1, 2024

Description

No longer used now that it has been split out into separate drivers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 1, 2024 10:51
@drashna drashna requested a review from a team January 1, 2024 20:24
@fauxpark fauxpark merged commit f583d2f into qmk:develop Jan 2, 2024
5 checks passed
@fauxpark fauxpark deleted the remove-is31common branch January 2, 2024 05:26
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
Remove IS31FLCOMMON code (qmk#22800)
698a56d
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
Remove IS31FLCOMMON code (qmk#22800)
e0352e4
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
Remove IS31FLCOMMON code (qmk#22800)
15df656
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Remove IS31FLCOMMON code (qmk#22800)
08d01ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr