Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Late9 keymaps update, added VIA support #22801

Merged
merged 19 commits into from
Feb 19, 2024
Merged

Late9 keymaps update, added VIA support #22801

merged 19 commits into from
Feb 19, 2024

Conversation

rookiebwoy
Copy link
Contributor

Description

  • removed multitap keymap
  • created via keymap
  • changed pid and vid in info.json
  • updated readme file to better fit the template
  • better comments overall

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support dependencies labels Jan 1, 2024
drashna
drashna requested changes Jan 1, 2024
View reviewed changes
keyboards/rookiebwoy/late9/readme.md Outdated Show resolved Hide resolved
keyboards/rookiebwoy/late9/rules.mk Outdated Show resolved Hide resolved
lib/chibios-contrib Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 13, 2024 08:30
zvecr
zvecr requested changes Jan 17, 2024
View reviewed changes
keyboards/rookiebwoy/late9/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/rookiebwoy/late9/rev1/info.json Outdated Show resolved Hide resolved
@rookiebwoy rookiebwoy requested a review from zvecr January 22, 2024 05:42
@zvecr zvecr merged commit 8df2e70 into qmk:develop Feb 19, 2024
3 checks passed
fpb pushed a commit to fpb/qmk_firmware that referenced this pull request Feb 19, 2024
@rookiebwoy @fpb
Late9 keymaps update, added VIA support (qmk#22801)
8779d5a
fpb added a commit to fpb/qmk_firmware that referenced this pull request Feb 20, 2024
@fpb
Revert "Late9 keymaps update, added VIA support (qmk#22801)"
dfa0f28 
This reverts commit 8779d5a.
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@rookiebwoy @nuess0r
Late9 keymaps update, added VIA support (qmk#22801)
9164c68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor left review comments

@fauxpark fauxpark fauxpark requested changes

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rookiebwoy @drashna @fauxpark @zvecr @lesshonor