Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H87g2 updates #22819

Merged
merged 14 commits into from
Feb 1, 2024
Merged

H87g2 updates #22819

merged 14 commits into from
Feb 1, 2024

Conversation

hineybush
Copy link
Contributor

Description

Updating h87 gen2 for functionality.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 3, 2024
zvecr
zvecr requested changes Jan 3, 2024
View reviewed changes
keyboards/hineybush/h87_g2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/chconf.h Outdated Show resolved Hide resolved
hineybush and others added 3 commits January 3, 2024 14:02
@hineybush @zvecr
Update keyboards/hineybush/h87_g2/keymaps/default/keymap.c
8150cb0 
Co-authored-by: Joel Challis <git@zvecr.com>
@hineybush @zvecr
Update keyboards/hineybush/h87_g2/keymaps/via/keymap.c
fdd2a45 
Co-authored-by: Joel Challis <git@zvecr.com>
@hineybush
remove file
2c58379
@hineybush hineybush mentioned this pull request Jan 3, 2024
Merged
7 tasks
dunk2k
dunk2k suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add community layouts based on respective PR in the-via/keyboards repo

keyboards/hineybush/h87_g2/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/info.json Show resolved Hide resolved
dunk2k
dunk2k suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keymap changes for Community Layout suggestion

keyboards/hineybush/h87_g2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
hineybush and others added 3 commits January 4, 2024 00:47
@hineybush @dunk2k
Update keyboards/hineybush/h87_g2/info.json
501eefb 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@hineybush @dunk2k
Update keyboards/hineybush/h87_g2/info.json
33524e6 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@hineybush @dunk2k
Apply suggestions from code review
aa5e43e 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
fauxpark
fauxpark requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates need to go through develop.

@hineybush
Copy link
Contributor Author

Keyboard updates need to go through develop.

Not sure what this means?

@dunk2k
Copy link
Contributor

dunk2k commented Jan 4, 2024

Keyboard updates need to go through develop.

Not sure what this means?

Edit this PR's base branch from master to develop. Instructions

@hineybush hineybush changed the base branch from master to develop January 4, 2024 18:57
@hineybush
Copy link
Contributor Author

Keyboard updates need to go through develop.

Not sure what this means?

Edit this PR's base branch from master to develop. Instructions

Gotcha, done. Is this a new policy? I've never done this before.

@dunk2k
Copy link
Contributor

dunk2k commented Jan 4, 2024

Gotcha, done. Is this a new policy? I've never done this before.

Listed in Keyboard PRs section of PR checklist 👍

drashna
drashna requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The new files are missing a trailing newline at the end of the file. Could you add?

keyboards/hineybush/h87_g2/halconf.h Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/hineybush/h87_g2/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/hineybush/h87_g2/mcuconf.h Outdated Show resolved Hide resolved
hineybush and others added 2 commits January 11, 2024 00:42
@hineybush @drashna
Apply suggestions from code review
f57cf6e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@hineybush
i think i fixed the tabs, idk
40a046e
@drashna drashna requested a review from a team January 13, 2024 08:25
dunk2k
dunk2k suggested changes Jan 13, 2024
View reviewed changes
keyboards/hineybush/h87_g2/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/mcuconf.h Outdated Show resolved Hide resolved
keyboards/hineybush/h87_g2/info.json Outdated Show resolved Hide resolved
hineybush and others added 3 commits January 22, 2024 19:59
@hineybush @dunk2k
Update keyboards/hineybush/h87_g2/info.json
b435a8f 
ok

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@hineybush @dunk2k
Update keyboards/hineybush/h87_g2/info.json
a9831ef 
ok

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@hineybush @dunk2k
Update keyboards/hineybush/h87_g2/mcuconf.h
8291e53 
ok

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@drashna drashna merged commit c390292 into qmk:develop Feb 1, 2024
3 checks passed
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@hineybush @zvecr
@dunk2k @drashna @nuess0r
H87g2 updates (qmk#22819)
e35d5bf 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hineybush @dunk2k @drashna @fauxpark @zvecr