Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WT boards: extract g_is31fl3736_leds from wt_mono_backlight #22823

Merged
merged 2 commits into from
Jan 7, 2024
Merged

WT boards: extract g_is31fl3736_leds from wt_mono_backlight #22823

merged 2 commits into from
Jan 7, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 4, 2024

Description

To further allow for these to be converted to LED Matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 4, 2024 09:22
@drashna drashna requested a review from a team January 7, 2024 03:01
@drashna
Copy link
Member

drashna commented Jan 7, 2024

Link doesn't like the lack of copyright headers

fauxpark
fauxpark commented Jan 7, 2024
View reviewed changes
keyboards/wilba_tech/wt60_a/wt60_a.c Show resolved Hide resolved
keyboards/wilba_tech/wt65_a/wt65_a.c Show resolved Hide resolved
keyboards/wilba_tech/wt65_b/wt65_b.c Show resolved Hide resolved
keyboards/wilba_tech/wt75_a/wt75_a.c Show resolved Hide resolved
keyboards/wilba_tech/wt75_b/wt75_b.c Show resolved Hide resolved
keyboards/wilba_tech/wt75_c/wt75_c.c Show resolved Hide resolved
keyboards/wilba_tech/wt80_a/wt80_a.c Show resolved Hide resolved
@fauxpark
Copy link
Member Author

fauxpark commented Jan 7, 2024

Just the existing keymaps failing lint now.

@fauxpark fauxpark merged commit 7114eb2 into qmk:develop Jan 7, 2024
2 of 3 checks passed
@fauxpark fauxpark deleted the wt-extract-3736-mono branch January 7, 2024 07:43
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
WT boards: extract g_is31fl3736_leds from wt_mono_backlight (qmk#22823
ab9906f 
)
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
WT boards: extract g_is31fl3736_leds from wt_mono_backlight (qmk#22823
2b6602c 
)
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
WT boards: extract g_is31fl3736_leds from wt_mono_backlight (qmk#22823
9e3fc6c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna