Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is31fl3733: change write_register() return type to void #22824

Merged
merged 1 commit into from
Jan 8, 2024
Merged

is31fl3733: change write_register() return type to void #22824

merged 1 commit into from
Jan 8, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 4, 2024 •
edited
Loading

Description

Never used, and is the only ISSI driver which write_register() function does this.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 4, 2024 10:14
@fauxpark fauxpark mentioned this pull request Jan 4, 2024
Merged
14 tasks
@drashna drashna requested a review from a team January 7, 2024 03:03
@zvecr zvecr merged commit 368a2eb into qmk:develop Jan 8, 2024
3 of 4 checks passed
@fauxpark fauxpark deleted the 3733-write-register-return-void branch January 8, 2024 05:00
@fauxpark fauxpark mentioned this pull request Jan 8, 2024
Merged
14 tasks
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
is31fl3733: change write_register() return type to void (qmk#22824)
4f65d46
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
is31fl3733: change write_register() return type to void (qmk#22824)
694385a
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
is31fl3733: change write_register() return type to void (qmk#22824)
cd19b0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr