Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is31fl3733: fix driver sync backwards compatibility defines #22851

Merged
merged 1 commit into from
Jan 7, 2024
Merged

is31fl3733: fix driver sync backwards compatibility defines #22851

merged 1 commit into from
Jan 7, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 7, 2024

Description

These ifdefs are wrong.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 7, 2024 06:42
@drashna drashna requested a review from a team January 7, 2024 06:43
@fauxpark fauxpark merged commit e5203f8 into qmk:develop Jan 7, 2024
2 of 3 checks passed
@fauxpark fauxpark deleted the 3733-sync-defines-fix branch January 7, 2024 06:46
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
is31fl3733: fix driver sync backwards compatibility defines (qmk#22851)
9566b41
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
is31fl3733: fix driver sync backwards compatibility defines (qmk#22851)
0d2fae5
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
is31fl3733: fix driver sync backwards compatibility defines (qmk#22851)
f132f90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna