Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED drivers: switch to i2c_writeReg() #22878

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

fauxpark
Copy link
Member

Description

It seems to me that this whole memcpy business to transmit the PWM buffers is a relic of the original ISSI driver(s) predating the i2c_master API.

Tested on 3731, appears to work just fine.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark merged commit 58696a3 into qmk:develop Jan 10, 2024
4 checks passed
@fauxpark fauxpark deleted the led-drivers-i2c-write-reg branch January 10, 2024 06:25
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants