Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup doio/kb16 #22921

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Fixup doio/kb16 #22921

merged 4 commits into from
Feb 1, 2024

Conversation

waffle87
Copy link
Member

Description

  • Adds NO_ACTION_ONESHOT to reduce size (macropad, so not much functionality lost)
  • Moves RGB matrix configuration to data drive
  • Moves duplicate keymaps and configuration to top level folder
  • Other misc tidying

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team January 19, 2024 01:24
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 19, 2024
@waffle87 waffle87 changed the title initial Fixup doio/kb16 Jan 19, 2024
zvecr
zvecr requested changes Jan 19, 2024
View reviewed changes
keyboards/doio/kb16/config.h Outdated Show resolved Hide resolved
keyboards/doio/kb16/config.h Outdated Show resolved Hide resolved
@waffle87 @drashna
Update keyboards/doio/kb16/rev1/info.json
1b942da 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team February 1, 2024 07:59
@zvecr zvecr merged commit 98f0c5e into qmk:develop Feb 1, 2024
3 checks passed
@waffle87 waffle87 deleted the refactor/kb16 branch February 2, 2024 16:02
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@waffle87 @nuess0r
Fixup doio/kb16 (qmk#22921)
5e8c3b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @drashna @zvecr