Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure LTO is enabled as a info.json build config option #22932

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Ensure LTO is enabled as a info.json build config option #22932

merged 2 commits into from
Feb 1, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 20, 2024 •
edited
Loading

Description

  • Removes duplicates
  • Migrates feature.lto -> build.lto
  • Updates schema to reject keys

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard python cli qmk cli command dd Data Driven Changes labels Jan 20, 2024
@zvecr zvecr changed the title Ensure LTO is enabled as a 'info.json` build config option Ensure LTO is enabled as a info.json build config option Jan 20, 2024
@lesshonor
Copy link
Contributor

Not sure if keymaps are out of scope here:

qmk_firmware/keyboards/moondrop/dash75/keymaps/via/keymap.json

Lines 9 to 12 in 1522695

"features": {
"via": true,
"lto": true
}

qmk_firmware/keyboards/thevankeyboards/minivan/keymaps/via/keymap.json

Lines 12 to 15 in 1522695

"features": {
"via": true,
"lto": true
},

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jan 21, 2024
@zvecr
Copy link
Member Author

zvecr commented Jan 21, 2024

Not sure if keymaps are out of scope here:

Good catch!

@drashna drashna requested a review from a team February 1, 2024 07:55
@zvecr zvecr merged commit 3a13c21 into develop Feb 1, 2024
4 of 6 checks passed
@zvecr zvecr deleted the reject_lto_feature branch February 1, 2024 15:46
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Ensure LTO is enabled as a info.json build config option (qmk#22932)
d9258c5 
* feature.lto -> build.lto

* keymaps too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command dd Data Driven Changes keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @lesshonor @drashna @fauxpark