Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sango Keyboard #22971

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Sango Keyboard #22971

merged 10 commits into from
Jan 29, 2024

Conversation

Aidan-OS
Copy link
Contributor

Description

Adding a new keyboard, the "Sango" an open source 65%ish choc keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Jan 27, 2024
View reviewed changes
keyboards/aidansmithdotdev/sango/sango.c Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/sango/readme.md Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/sango/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/sango/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/sango/config.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team January 27, 2024 09:07
@waffle87 waffle87 requested a review from a team January 28, 2024 07:01
@Aidan-OS @waffle87
Update keyboards/aidansmithdotdev/sango/rules.mk
d6950a0 
Co-authored-by: jack <0x6a73@protonmail.com>
@Aidan-OS
Copy link
Contributor Author

I'm unsure why this says there is a change requested, I'm fairly sure I've made all the requested changes.

@drashna drashna merged commit ca7b2d6 into qmk:develop Jan 29, 2024
3 checks passed
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Aidan-OS @fauxpark
@waffle87 @nuess0r
Sango Keyboard (qmk#22971)
67ff8c0 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aidan-OS @drashna @fauxpark @waffle87