Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dip switch config to info.json - keychron #23037

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Migrate dip switch config to info.json - keychron #23037

merged 1 commit into from
Feb 9, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 8, 2024 •
edited
Loading

Description

Migrates pin/matrix config for keychron boards. Follow up to 22437.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team February 8, 2024 09:34
@zvecr zvecr merged commit 137938b into develop Feb 9, 2024
3 checks passed
@zvecr zvecr deleted the dip_tidy2 branch February 9, 2024 06:56
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Migrate dip switch config to info.json - keychron (qmk#23037)
fc747d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark