LED drivers: update PWM register defines for g_<driver>_leds
#23052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These drivers have a mixture of naming conventions for the PWM register defines used for mapping LED channels. Some use an alphanumeric "matrix location" (
A_1
etc), where others useCSx_SWy
. The latter is almost correct but should be flipped (SWx_CSy
) to better reflect the ordering.This is an effort to clarify and "standardise" them, by using the pin names from the datasheet instead which should be less prone to naming collisions.
AW20216S:
CS1_SW1-CS18_SW12
->SW1_CS1-SW12_CS18
IS31FL3733:
A_1-L_16
->SW1_CS1-SW12_CS16
IS31FL3736:
A_1-L_8
->SW1_CS1-SW12_CS8
IS31FL3737:
A_1-L_12
->SW1_CS1-SW12_CS12
IS31FL3742A:
CS1_SW1-CS30_SW6
->SW1_CS1-SW6_CS30
IS31FL3743A:
CS1_SW1-CS18_SW11
->SW1_CS1-SW11_CS18
IS31FL3745:
CS1_SW1-CS18_SW8
->SW1_CS1-SW8_CS18
IS31FL3746A:
CS1_SW1-CS18_SW4
->SW1_CS1-SW4_CS18
SNLED27351:
A_1-L_16
->CB1_CA1-CB12_CA16
IS31FL3731 uses a charlieplex configuration; for now I have left it alone but may revisit it.
IS31FL3741 is waiting on #23049 which also touches these defines.
Defines for backwards compatibility have been added for the drivers currently used in the repo.
Types of Changes
Issues Fixed or Closed by This PR
Checklist