Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git-submodule running in wrong location #23059

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 12, 2024

Description

When config or environment variable point to an invalid location, normpath can return a directory that does not reflect the change of directory performed by the cli. We never want current directory paths, so the code has been updated to just use regular pathlib funcs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Feb 12, 2024
@github-actions github-actions bot added python cli qmk cli command labels Feb 12, 2024
@zvecr zvecr merged commit 98a68b6 into develop Feb 12, 2024
5 checks passed
@zvecr zvecr deleted the fix_submodule_cli branch February 12, 2024 10:02
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants