Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nacly/sodium62: Update vid, pid, and add via keymap #23063

Merged
merged 2 commits into from
Feb 14, 2024
Merged

nacly/sodium62: Update vid, pid, and add via keymap #23063

merged 2 commits into from
Feb 14, 2024

Conversation

Na-Cly
Copy link
Contributor

@Na-Cly Na-Cly commented Feb 12, 2024 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 12, 2024
@waffle87 waffle87 requested a review from a team February 12, 2024 23:29
fauxpark
fauxpark requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates need to go through develop.

@Na-Cly
Copy link
Contributor Author

Na-Cly commented Feb 13, 2024

Based off the develop branch? I'm not sure what go through develop means.

@fauxpark fauxpark changed the base branch from master to develop February 13, 2024 01:08
@Na-Cly Na-Cly requested a review from fauxpark February 14, 2024 01:03
@zvecr zvecr merged commit 51a1e3d into qmk:develop Feb 14, 2024
3 checks passed
@Na-Cly Na-Cly mentioned this pull request Apr 3, 2024
Merged
7 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Na-Cly @nuess0r
Update vid, pid, and add via keymap (qmk#23063)
aedf54c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Na-Cly @fauxpark @zvecr @waffle87