Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix pmw33xx sensor corruption on get-cpi call #23116

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

drashna
Copy link
Member

@drashna drashna commented Feb 19, 2024

Description

Initially reported by Wimads and burkfers on the BastardKB discord.

The bug with PMW3360 I was talking about a week ago or so, with DPI's of 100, 900, 1700, etc not working. We figured out it was caused by pointing_device_get_cpi() Calling that at those DPI settings, causes mouse reports to break (no reports coming in). Setting cpi right after getting it fixes the issue. So something is going wrong with the get_cpi call.

This sounds like a bug with the pmw3360 firmware itself. But for now, this is a quick fix to the issue that is confirmed to work.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

  • Issue reported on BastardKB discord

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 19, 2024 22:30
@tzarc tzarc merged commit 6678078 into qmk:develop Feb 20, 2024
2 of 3 checks passed
@drashna drashna deleted the fix/pmw33xx_cpi branch February 20, 2024 00:41
peepeetee pushed a commit to peepeetee/qmk_firmware that referenced this pull request Mar 12, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants