Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for STM32WB #23544

Closed
wants to merge 2 commits into from
Closed

Add support for STM32WB #23544

wants to merge 2 commits into from

Conversation

JackyJia73
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Add support for STM32WB

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member

tzarc commented Apr 17, 2024

At this stage we're not including core-defined support for new MCUs unless there's at least one corresponding keyboard for them. All of these items can be specified in rules.mk directly inside a keyboard definition -- it'll be up to the QMK team to determine if/when we should be breaking it out and making a common definition.

@tzarc tzarc closed this Apr 17, 2024
@tzarc
Copy link
Member

tzarc commented Apr 17, 2024

See #23392 as an example of in-keyboard definition.

@JackyJia73
Copy link
Contributor Author

@tzarc How about update a working kb the same time? Thanks

@tzarc
Copy link
Member

tzarc commented Apr 18, 2024

@tzarc How about update a working kb the same time? Thanks

That’s fine, so long as the definitions for the MCU still reside in the keyboard. QMK maintainers will choose when to support it in core definitions.

@JackyJia73 JackyJia73 deleted the stm32wb branch June 12, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants