Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing RK G68, not compatible with QMK #24274

Closed
wants to merge 0 commits into from

Conversation

Thomaz-Peres
Copy link
Contributor

@Thomaz-Peres Thomaz-Peres commented Aug 13, 2024

Description

Removing the RK G68 because it isn't compatible with the QMK. This is confusing many people trying to use the Royal Kludge. Sorry about that

I don't know how the rules to removing something work (I've searched in the docs, but didn't find anything), and this probably doesn't happen often, but following the Thread here, it's okay.

Please let me know if something is wrong

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 13, 2024
@zvecr
Copy link
Member

zvecr commented Aug 13, 2024

Removing the RK G68 because it isn't compatible with the QMK

If that were the case, how did it get to the point of being added? It would suggest the initial submission had not been tested on hardware.

@Nano204
Copy link

Nano204 commented Sep 9, 2024

I was trying to use QMK with my RKG68 keyboard and it didn't work. So I'm completely agree with this PR, it seems it needs to be rebased @Thomaz-Peres so it can be marge as @drashna already approved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants