Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Klor #24302

Merged
merged 5 commits into from
Sep 6, 2024
Merged

[Keyboard] Add Klor #24302

merged 5 commits into from
Sep 6, 2024

Conversation

waffle87
Copy link
Member

Description

Adding Klor keyboard due to this keyboard's popularity and the available firmware being very incompatible with modern QMK.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team August 18, 2024 17:54
If physical device is not installed, the cursor on some systems
can drift erroneously.
@azzamsa
Copy link

azzamsa commented Sep 5, 2024

Just dropping in to do the same thing! I've seen a lot of posts on Reddit and Discord asking for a working KLOR firmware. I have my own up-to-date version, but I’ve stripped out everything I don’t need. I’ve been hesitant to make a PR because I’m not too familiar with certain parts, mainly the RP2040 version and the trackball library.

Once this PR is merged, I’ll be able to keep everything in my qmk_userspace without having to switch back and forth between qmk_firmware branches.

Thanks so much for doing this!

@drashna drashna requested a review from a team September 6, 2024 05:55
@drashna drashna merged commit 6d4f8d8 into qmk:master Sep 6, 2024
3 checks passed
@waffle87 waffle87 deleted the kb/klor branch September 6, 2024 16:32
azzamsa added a commit to azzamsa/qmk_userspace that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants