Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Singa Kohaku #24309

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[Keyboard] Add Singa Kohaku #24309

wants to merge 11 commits into from

Conversation

itsme-zeix
Copy link
Contributor

@itsme-zeix itsme-zeix commented Aug 20, 2024

Description

Add support for Singa Kohaku R2 PCB (Designed by Zeix).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 20, 2024
keyboards/zeix/singa/kohaku/keyboard.json Outdated Show resolved Hide resolved
itsme-zeix and others added 2 commits August 21, 2024 23:07
Co-authored-by: jack <jack@pngu.org>
GP20 has already been specified under the flags in ws2812

Co-authored-by: Joel Challis <git@zvecr.com>
keyboards/zeix/singa/kohaku/matrix_diagram.md Outdated Show resolved Hide resolved
keyboards/zeix/singa/kohaku/keyboard.json Outdated Show resolved Hide resolved
keyboards/zeix/singa/kohaku/keyboard.json Outdated Show resolved Hide resolved
itsme-zeix and others added 4 commits August 25, 2024 01:56
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@itsme-zeix itsme-zeix requested a review from dunk2k August 24, 2024 18:07
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.
Copy

keyboards/zeix/singa/kohaku/keyboard.json Outdated Show resolved Hide resolved
@itsme-zeix
Copy link
Contributor Author

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead. Copy

Removed ./keymaps/via.

@zvecr zvecr removed the via Adds via keymap and/or updates keyboard for via support label Aug 28, 2024
@drashna drashna requested review from a team and removed request for dunk2k August 30, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants