Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new keyboard - ic45v2 (custom pcb 45%) #24818

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Added a new keyboard - ic45v2 (custom pcb 45%) #24818

merged 4 commits into from
Jan 18, 2025

Conversation

lighteningAB
Copy link
Contributor

New Keyboard, 45%

image
WhatsApp Image 2024-10-18 at 14 39 21_48ea77ac
adding my keyboard into qmk, built 5 and distributed to friends so would want them to be able to program if they wanted to

New Keyboard

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Jan 16, 2025
View reviewed changes
keyboards/handwired/ic45_v2/keyboard.json Outdated Show resolved Hide resolved
keyboards/handwired/ic45_v2/keyboard.json Outdated Show resolved Hide resolved
keyboards/handwired/ic45_v2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ic45_v2/readme.md Outdated Show resolved Hide resolved
@lighteningAB @waffle87
Apply suggestions from code review
020edf3 
Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>
@lighteningAB lighteningAB requested a review from waffle87 January 16, 2025 06:05
@waffle87 waffle87 requested a review from a team January 16, 2025 16:21
@lighteningAB @drashna
Update keyboards/handwired/ic45_v2/keyboard.json
ea12d6b 
adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>
@waffle87 waffle87 merged commit 6b368f4 into qmk:master Jan 18, 2025
3 checks passed
le4ker pushed a commit to le4ker/lily58-firmware that referenced this pull request Jan 19, 2025
@lighteningAB @waffle87
@drashna @le4ker
[Keyboard] Add ic45v2 (qmk#24818)
4f4a910 
* adding in ic45 handwired

* fix wrong title

* Apply suggestions from code review

Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>

* Update keyboards/handwired/ic45_v2/keyboard.json

adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: jack <jack@pngu.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
vinniefranco pushed a commit to Good-Great-Grand-Wonderful/qmk_firmware that referenced this pull request Jan 20, 2025
@lighteningAB @waffle87 @drashna
[Keyboard] Add ic45v2 (qmk#24818)
b6fefe9 
* adding in ic45 handwired

* fix wrong title

* Apply suggestions from code review

Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>

* Update keyboards/handwired/ic45_v2/keyboard.json

adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: jack <jack@pngu.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
alk-alyss added a commit to alk-alyss/qmk_firmware that referenced this pull request Jan 30, 2025
@alk-alyss
Merge branch 'master' of https://github.com/qmk/qmk_firmware
07d8f40 
* 'master' of https://github.com/qmk/qmk_firmware: (221 commits)
  Add Keychron C3 Pro (Red & RGB) (qmk#24874)
  [OS Detection] Improve MacOS detection (qmk#24708)
  Bump vite from 5.2.14 to 5.4.12 in /builddefs/docsgen (qmk#24852)
  Reject keyboard.json next to info.json (qmk#24882)
  Add keyboard clap_studio/flame60 (qmk#24870)
  [Keyboard] Add Support E8ghtyNeo (qmk#24859)
  [License Violation] add pressplayid (qmk#24869)
  Fix missing wait.h include in Dip Switch Map (qmk#24863)
  Add Model-B keyboard (qmk#24681)
  Updated Licence Violations for Chosfox L75 (qmk#24833)
  License violations updates. (qmk#24831)
  Add Lily (qmk#24813)
  `kikoslab/kl90`: fix keymap (qmk#24826)
  [Keyboard] Add ic45v2 (qmk#24818)
  Allow running Docker container on MacOS (without in-container USB support) (qmk#24412)
  `salane/ncr80alpsskfl`: add additional layouts (qmk#24809)
  Bump nanoid from 3.3.7 to 3.3.8 in /builddefs/docsgen (qmk#24713)
  Fix a build warning and tidy up a keymap (qmk#24805)
  [Bug] Fix Underglow keycode processing (qmk#24798)
  [Docs] Fix wording in Mod Tap documentation (qmk#24796)
  ...
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@lighteningAB @waffle87
@drashna @Rumadon
[Keyboard] Add ic45v2 (qmk#24818)
d0af3e5 
* adding in ic45 handwired

* fix wrong title

* Apply suggestions from code review

Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>

* Update keyboards/handwired/ic45_v2/keyboard.json

adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: jack <jack@pngu.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@lighteningAB @waffle87 @drashna
[Keyboard] Add ic45v2 (qmk#24818)
2dc5992 
* adding in ic45 handwired

* fix wrong title

* Apply suggestions from code review

Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>

* Update keyboards/handwired/ic45_v2/keyboard.json

adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: jack <jack@pngu.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@lighteningAB @waffle87
@drashna @alinelena
[Keyboard] Add ic45v2 (qmk#24818)
c3b3f28 
* adding in ic45 handwired

* fix wrong title

* Apply suggestions from code review

Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>

* Update keyboards/handwired/ic45_v2/keyboard.json

adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: jack <jack@pngu.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
thomasc791 pushed a commit to thomasc791/qmk_firmware that referenced this pull request Feb 4, 2025
@lighteningAB @waffle87
@drashna @thomasc791
[Keyboard] Add ic45v2 (qmk#24818)
e07aba6 
* adding in ic45 handwired

* fix wrong title

* Apply suggestions from code review

Thank you @waffle87

Co-authored-by: jack <jack@pngu.org>

* Update keyboards/handwired/ic45_v2/keyboard.json

adding whitespace

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: jack <jack@pngu.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@fauxpark fauxpark fauxpark approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lighteningAB @drashna @fauxpark @waffle87