-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new keyboard Handwired/cheapwire #24884
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can/should be removed. Most of these settings are things that should be set per user (eg, at keymap level), and the rest are mostly just comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be renamed to keyboard.json
"pid": "0x2416", | ||
"vid": "0x4351" | ||
}, | ||
"layouts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"layouts": { | |
"community_layouts": [ "split_3x6_3" ], | |
"layouts": { |
] | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
@@ -0,0 +1,21 @@ | |||
# handwired/cheapwire | |||
|
|||
![handwired/cheapwire](https://github.com/cocolizo945/qmk_firmware/assets/81886929/4061c9e0-0de0-4f59-882a-e559f994c122) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image should be rehosted on dedicated image hosting site, such as imgur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be removed.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist